[vortex] 3c905CX things
Fri, 5 Jan 2001 09:02:46 +0100 (CET)
On Mon, 1 Jan 2001, Andrew Morton wrote:
> ... however he wouldn't have exercised the other
> RxReset in vortex_error().
Why should this be different ?
> It _is_ safe to schedule() within vortex_up(). It's not safe
> to schedule() in vortex_probe() because of the probe/open race.
> So long-term, a schedule_timeout(1) is a better approach to handling
> the RxReset timer.
So you want a timer to take care of this case ? How about vortex_error
which is called from ISR ?
> The change to the MII scan order works fine. In fact, this is
> what 3com recommend in the 905C document: look at index 24 first.
Still, the code is checking 24, 1->23, 0, 25-31. I think that 24, 1->31, 0
is better. Code is in:
and it should also make obsolete the mdio_read(ioaddr, 24, 1) just before
the MII scanning.
IWR - Interdisziplinaeres Zentrum fuer Wissenschaftliches Rechnen
Universitaet Heidelberg, INF 368, D-69120 Heidelberg, GERMANY
Telephone: +49 6221 54 8869, Telefax: +49 6221 54 8868