[eepro100] Simple patch for 815E chipset

Donald Becker becker@scyld.com
Tue, 1 Aug 2000 11:15:27 -0400 (EDT)


On Tue, 1 Aug 2000, Robert J.Dunlop wrote:

> I was recently asked to install Linux on an Intel D815EEA motherboard (Intel
> chipset 815E) which contains an intergrated Intel Pro100 network interface.
> Whilst the driver did not work out the box I found that all that was necessary
> was to add the new device ID to the list of those supported.
>
> This patch is against the driver I found with kernel 2.2.16
> static const char *version =
> "eepro100.c:v1.09j-t 9/29/99 Donald Becker ...
> "eepro100.c: $Revision: 1.20.2.10 $ 2000/05/31 Modified ...

This ID was reported by Chas Wareing c3w@isp..net and is already in v1.11
    ftp://www.scyld.com/pub/network/test/eepro100.c

The new entry uses the ID string
   "Intel i82562 EEPro100"
Does this match the chip part number on your implementation?

>   #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
>   #endif
> + #ifndef PCI_DEVICE_ID_INTEL_ID2449
> + #define PCI_DEVICE_ID_INTEL_ID2449 0x2449
> + #endif
...
> + 	{ "Intel D815EEA motherboard Pro100/V",
> + 	  PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID2449,

I know that this looks like the obvious way to add new entries, but I've
changed to just using the numeric constant directly.  The text name in the
table is more descriptive, and there isn't the problem of pci.h changing the
name.  What is the reason for a symbolic name when the value is constant for
all time, is only used once and the name carries no information.


Donald Becker				becker@scyld.com
Scyld Computing Corporation		http://www.scyld.com
410 Severn Ave. Suite 210		Beowulf Clusters / Linux Installations
Annapolis MD 21403